Conversation
Find Lexical Entry now matches typed characters anywhere in a word for queries of 3+ characters, using liblcm's new SearchType.Substring; shorter queries keep the original full-text search. The mode decision lives in a unit-tested SubstringSearchPolicy, and results retain the existing exact -> starts-with -> anywhere ordering.
Comment hygiene (advisory)No comment-style violations in the lines this branch adds since |
added 2 commits
August 25, 2026 17:41
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
==========================================
- Coverage 38.35% 38.35% -0.01%
==========================================
Files 1507 1508 +1
Lines 350617 350641 +24
Branches 40298 40301 +3
==========================================
+ Hits 134471 134480 +9
- Misses 186916 186931 +15
Partials 29230 29230
🚀 New features to boost your workflow:
|
ResetMatches now swaps the matching browser's search engine on each query to move between full-text and substring modes. That swap always installed an EntryGoDlg-owned engine, replacing the MergeEntryDlg engine that excludes the starting entry. As soon as the Merge Entry dialog set its form text (or the user typed), the starting entry reappeared in the list and could be merged into itself. Make the full-text and substring engine accessors virtual on EntryGoDlg so MergeEntryDlg can supply engines that exclude the starting entry in both modes, and drop MergeEntryDlg's InitializeMatchingObjects override now that the base engine selection handles it. Add tests covering the exclusion in full-text and substring modes. Co-Authored-By: Claude <noreply@anthropic.com>
thejambi
marked this pull request as ready for review
August 26, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Summary
Find Lexical Entry now matches typed characters anywhere in a word for queries of 3+ characters, using liblcm's new SearchType.Substring; shorter queries keep the original full-text search. The mode decision lives in a unit-tested SubstringSearchPolicy, and results retain the existing exact -> starts-with -> anywhere ordering.
Depends on sillsdev/liblcm#395
https://jira.sil.org/browse/LT-22524
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).Docs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.Notes for reviewers (optional)
This change is